Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flutter_plugin): throws PubspecNotFound exception #199

Merged
merged 15 commits into from
Oct 6, 2021
Merged

fix(flutter_plugin): throws PubspecNotFound exception #199

merged 15 commits into from
Oct 6, 2021

Conversation

marcossevilla
Copy link
Contributor

Description

  • Runs flutter packages get and dart fix --apply for every platform directory on flutter plugin template when it's generated.
  • Minor update to flutter plugin template as the CLI generates a higher level folder with project name so it's no longer needed on the template.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@marcossevilla marcossevilla added the bug Something isn't working as expected label Oct 1, 2021
@marcossevilla marcossevilla self-assigned this Oct 1, 2021
felangel
felangel reviewed Oct 5, 2021
View reviewed changes
lib/src/cli/dart_cli.dart Outdated Show resolved Hide resolved
felangel
felangel reviewed Oct 5, 2021
View reviewed changes
lib/src/cli/dart_cli.dart Outdated Show resolved Hide resolved
felangel
felangel reviewed Oct 5, 2021
View reviewed changes
lib/src/cli/dart_cli.dart Outdated Show resolved Hide resolved
@felangel felangel merged commit 8d040cc into main Oct 6, 2021
@felangel felangel deleted the fix/flutter-packages-get-plugin branch October 6, 2021 03:00
@felangel felangel mentioned this pull request Oct 7, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

Assignees

@marcossevilla marcossevilla

Labels
bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcossevilla @felangel