Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): run tests with --no-pub #322

Merged
merged 1 commit into from
Mar 18, 2022
Merged

fix(test): run tests with --no-pub #322

merged 1 commit into from
Mar 18, 2022

Conversation

felangel
Copy link
Contributor

Description

  • fix(test): run tests with --no-pub

Context

When running tests without --no-pub if a warning is output during package installation, it is reported via stderr so the test_runner interprets it as an error and exits the process. This change always uses --no-pub during test execution to resolve this issue.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the bug Something isn't working as expected label Mar 18, 2022
@felangel felangel self-assigned this Mar 18, 2022
@felangel felangel merged commit 005c2aa into main Mar 18, 2022
@felangel felangel deleted the fix/test-no-pub branch March 18, 2022 18:52
@felangel felangel mentioned this pull request Mar 21, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants