Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): exit (non-zero) on test failure #344

Merged
merged 4 commits into from
Mar 29, 2022
Merged

fix(test): exit (non-zero) on test failure #344

merged 4 commits into from
Mar 29, 2022

Conversation

felangel
Copy link
Contributor

Description

  • fix(test): exit (non-zero) on test failure

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the bug Something isn't working as expected label Mar 28, 2022
@felangel felangel self-assigned this Mar 28, 2022
erickzanardo
erickzanardo previously approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lib/src/cli/flutter_cli.dart Show resolved Hide resolved
@felangel @erickzanardo
Update lib/src/cli/flutter_cli.dart
4115c4d 
Co-authored-by: Erick <erickzanardoo@gmail.com>
@felangel felangel merged commit 828fb51 into main Mar 29, 2022
@felangel felangel deleted the fix/test-exit-when-tests-fail branch March 29, 2022 00:11
@felangel felangel mentioned this pull request Mar 30, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo left review comments

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

Assignees

@felangel felangel

Labels
bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felangel @erickzanardo