Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): cleanup .test_runner.dart on failure #348

Merged
merged 1 commit into from
Mar 30, 2022
Merged

fix(test): cleanup .test_runner.dart on failure #348

merged 1 commit into from
Mar 30, 2022

Conversation

felangel
Copy link
Contributor

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the bug Something isn't working as expected label Mar 29, 2022
@felangel felangel self-assigned this Mar 29, 2022
wolfenrain
wolfenrain previously approved these changes Mar 29, 2022
View reviewed changes
erickzanardo
erickzanardo previously approved these changes Mar 29, 2022
View reviewed changes
@felangel felangel dismissed stale reviews from erickzanardo and wolfenrain via 7e6100c March 29, 2022 22:50
@felangel felangel force-pushed the fix/test-cleanup-on-failure branch from 931a456 to 7e6100c Compare March 29, 2022 22:50
@felangel felangel force-pushed the fix/test-cleanup-on-failure branch from 48d8d11 to 21f05cf Compare March 30, 2022 18:09
@felangel felangel merged commit 548e872 into main Mar 30, 2022
@felangel felangel deleted the fix/test-cleanup-on-failure branch March 30, 2022 18:18
@felangel felangel mentioned this pull request Mar 30, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain approved these changes

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

Assignees

@felangel felangel

Labels
bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: .test_runner.dart does not get cleared up if the test command fails or gets interrupted.
3 participants
@felangel @erickzanardo @wolfenrain