Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow specifying an empty string as a Glob #703

Closed
alestiago opened this issue Mar 28, 2023 · 0 comments · Fixed by #704
Closed

fix: allow specifying an empty string as a Glob #703

alestiago opened this issue Mar 28, 2023 · 0 comments · Fixed by #704
Assignees
@alestiago
Labels
bug Something isn't working as expected

Comments

@alestiago
Copy link
Contributor

alestiago commented Mar 28, 2023 •
edited

Description
When using Very Good CLI 0.12.3 doing:

very_good packages get -r --ignore=""

Shows:

Error on line 1, column 1: expected a glob.
  ╷
1 │ 
  │ ^
  ╵

Steps To Reproduce

  1. Run very_good packages get -r --ignore="" in a valid directory

Expected Behavior
To accept an empty string as input.

Additional Context
Would simplify feat/support-excluding-directories default parameter.
@alestiago alestiago added the bug Something isn't working as expected label Mar 28, 2023
@alestiago alestiago mentioned this issue Mar 28, 2023
Merged
7 tasks
@alestiago alestiago self-assigned this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alestiago alestiago

Labels
bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support ignoring empty globs VeryGoodOpenSource/very_good_cli
1 participant
@alestiago