Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing error! #95

Closed
maxzod opened this issue Dec 20, 2021 · 2 comments · Fixed by #104
Closed

parsing error! #95

maxzod opened this issue Dec 20, 2021 · 2 comments · Fixed by #104
Assignees
Labels
feature A new feature or request good first issue Good for newcomers

Comments

@maxzod
Copy link

maxzod commented Dec 20, 2021

Describe the bug
parsing error!

To Reproduce
write a test witout using any code from the project
for example

void main() {
  test(
    '',
    () => expect(true, isTrue),
  );
}

then running the test will work and create empty lcov.info file which will throw this error

Expected behavior
fail and mention the coverage is 0%

Additional context
i know it does't make sense to write a test like this but in my case it makes sense to fail and mention that the failure reson is the coverage is 0%

@jorgecoca
Copy link
Contributor

Hi @maxzod 👋

Thank you for opening this issue. Personally, I think it makes sense to throw an error if the lcov report is empty, since empty and 0% coverage can be different things.

Have you considered running a custom script before very_good_coverage to check if the lcov.info file is empty or not? That might give you more control over the type of message you want to provide.

Thoughts?

Thank you!

@maxzod
Copy link
Author

maxzod commented Dec 20, 2021

Have you considered running a custom script before very_good_coverage to check if the lcov.info file is empty or not ?

yes this makes since but i didi't think about it 😅

still showing another message will help more ,

it took me almost 25 commits to the yml file to figure out what causes the parsing error !

if 0% is not a good fit then another error message will be nice at least we will know where to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants