Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#95: HTTP Fetcher rewritten using OKHTTP3 #109

Merged
merged 14 commits into from
Aug 9, 2017
Merged

#95: HTTP Fetcher rewritten using OKHTTP3 #109

merged 14 commits into from
Aug 9, 2017

Conversation

maqzi
Copy link
Member

@maqzi maqzi commented Jul 15, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.0%) to 45.126% when pulling 11dc319 on maqzi:rewriteFetcher into 0c848ba on ViDA-NYU:master.

@maqzi
pull new fetcher
dc3f241 
Merge branch 'rewriteFetcher' of https://github.com/maqzi/ache into rewriteFetcher
aecio
aecio reviewed Jul 20, 2017
View reviewed changes
Copy link
Member

@aecio aecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR already fix the SNI problem from issue #95?

src/main/java/focusedCrawler/crawler/async/fetcher/CustomCipherSuites.java Outdated
CipherSuite.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
CipherSuite.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
CipherSuite.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
// CipherSuite.SSL_DHE_DSS_EXPORT_WITH_DES40_CBC_SHA,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why these are commented out?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 45.559% when pulling 30e92c5 on maqzi:rewriteFetcher into 0c848ba on ViDA-NYU:master.

@maqzi
merging-fetcher again
c5f8ff4 
Merge branch 'rewriteFetcher' of https://github.com/maqzi/ache into rewriteFetcher
@maqzi
added tests
f9c8faa
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 46.708% when pulling f9c8faa on maqzi:rewriteFetcher into 0c848ba on ViDA-NYU:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 46.51% when pulling 4fb5722 on maqzi:rewriteFetcher into 0c848ba on ViDA-NYU:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 46.51% when pulling 31ede49 on maqzi:rewriteFetcher into 5f5df3d on ViDA-NYU:master.

@aecio aecio changed the title HTTP Fetcher rewritten using OKHTTP3 #95:HTTP Fetcher rewritten using OKHTTP3 Aug 2, 2017
@aecio aecio changed the title #95:HTTP Fetcher rewritten using OKHTTP3 #95: HTTP Fetcher rewritten using OKHTTP3 Aug 2, 2017
@aecio aecio merged commit 484de1a into VIDA-NYU:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aecio aecio aecio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maqzi @coveralls @aecio