[WIP] Issue #144 - Re-implement classifiers using SMILE library #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anudeepti2004
changed the title
aecio
reviewed
Dec 6, 2017
| }); | ||
| String modelFilePath = outputPath + "/pageclassifier.model"; | ||
| ArffParser arffParser = new ArffParser(); | ||
| arffParser.setResponseIndex(7486); |
aecio
reviewed
Dec 6, 2017
| // instanceWeka.setDataset(instances); | ||
| // double[] prob = classifier.distributionForInstance(instanceWeka); | ||
| double[] prob = new double[2]; | ||
| int predictedValue = ((SVM) classifier).predict(values, prob); |
There was a problem hiding this comment.
You should be using SoftClassifier interface instead of Classifier, then you wouldn't need to do a cast, and the code would work with any classifier algorithm implementation. Down casting is usually a code smell.
There was a problem hiding this comment.
I will change that and test again.
| vectorAtt.addElement(new weka.core.Attribute("class", classAtt)); | ||
| Instances insts = new Instances("link_classification", vectorAtt, 1); | ||
| insts.setClassIndex(attributes.length); | ||
| // weka.core.FastVector vectorAtt = new weka.core.FastVector(); |
There was a problem hiding this comment.
Please remove all old, comment code when the PR is done.
There was a problem hiding this comment.
Sure.. Will do.
aecio
changed the title
aecio
changed the title
aecio
requested changes
Dec 16, 2017
There was a problem hiding this comment.
A left a few inline comments that need to be resolved. Besides these, there are only two more things left:
- The docs need to be updated (http://ache.readthedocs.io/en/latest/page-classifiers.html#pageclassifier-weka)
- The code changes are using the formatting is using tabs instead of 4 spaces. Need to use 4 spaces for tabs and format according the google style guide (https://github.com/ViDA-NYU/ache#contributing).
| Classifier classifier = new weka.classifiers.functions.SMO(); | ||
| classifier.setOptions(weka.core.Utils.splitOptions("-C 1.0 -L 0.0010 -P 1.0E-12 -N 0 -M -V -1 -W 1 -K \"weka.classifiers.functions.supportVector.PolyKernel -C 250007 -E 1.0\" -no-cv")); | ||
| classifier.buildClassifier(data); | ||
| classifier.learn(smileInput.x(), y); |
There was a problem hiding this comment.
Platt's scalling needs to be trained here too, otherwise scores will not be valid!
| weka.core.Instance instanceWeka = new weka.core.Instance(1, values); | ||
| instanceWeka.setDataset(instances); | ||
| result = classifier.distributionForInstance(instanceWeka); | ||
| ((SVM<double[]>) classifier).predict(values, result); //predict returns int |
There was a problem hiding this comment.
This cast to SVM needs to be removed too!
| @@ -39,7 +39,8 @@ dependencies { | |||
| compile 'org.apache.tika:tika-parsers:1.14' | |||
| compile 'com.syncthemall:boilerpipe:1.2.2' | |||
| compile 'net.sourceforge.nekohtml:nekohtml:1.9.22' | |||
| compile 'nz.ac.waikato.cms.weka:weka-stable:3.6.13' | |||
| //compile 'nz.ac.waikato.cms.weka:weka-stable:3.6.13' | |||
There was a problem hiding this comment.
Remember to remove this commented line.
aecio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all classifiers from Weka by SMILE. Fixes #144 .