Don't write null criteria for unknown advancements

ViaVersion · May 7, 2024 · 072b590 · 072b590
1 parent 633b4b3
commit 072b590
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/...src/main/java/com/viaversion/viabackwards/provider/BukkitAdvancementCriteriaProvider.java b/...src/main/java/com/viaversion/viabackwards/provider/BukkitAdvancementCriteriaProvider.java
@@ -24,12 +24,11 @@
 
 public final class BukkitAdvancementCriteriaProvider extends AdvancementCriteriaProvider {
 
+    private static final String[] EMPTY_CRITERIA = new String[0];
+
     @Override
     public String[] getCriteria(final String key) {
         final Advancement advancement = Bukkit.getAdvancement(NamespacedKey.fromString(key));
-        if (advancement == null) {
-            return null;
-        }
-        return advancement.getCriteria().toArray(new String[0]);
+        return advancement == null ? EMPTY_CRITERIA : advancement.getCriteria().toArray(EMPTY_CRITERIA);
     }
 }