Remove empty item tags

Fixes #752
ViaVersion · May 21, 2024 · d7f550f · d7f550f
1 parent a9ed655
commit d7f550f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/...version/viabackwards/protocol/v1_20_5to1_20_3/rewriter/BlockItemPacketRewriter1_20_5.java b/...version/viabackwards/protocol/v1_20_5to1_20_3/rewriter/BlockItemPacketRewriter1_20_5.java
@@ -319,7 +319,13 @@ private static int colorId(final String color) {
         if (item == null) return null;
 
         super.handleItemToClient(connection, item);
-        return vvProtocol.getItemRewriter().toOldItem(connection, item, DATA_CONVERTER);
+
+        final Item oldItem = vvProtocol.getItemRewriter().toOldItem(connection, item, DATA_CONVERTER);
+        if (oldItem.tag() != null && oldItem.tag().isEmpty()) {
+            // Improve item equality checks by removing empty tags
+            oldItem.setTag(null);
+        }
+        return oldItem;
     }
 
     @Override

diff --git a/...viaversion/viabackwards/protocol/v1_20_5to1_20_3/rewriter/EntityPacketRewriter1_20_5.java b/...viaversion/viabackwards/protocol/v1_20_5to1_20_3/rewriter/EntityPacketRewriter1_20_5.java
@@ -70,9 +70,7 @@ public void registerPackets() {
             do {
                 slot = wrapper.read(Types.BYTE);
                 if (slot == 6) {
-                    //TODO
-                    // Body to... something else? the actual inventory slot is still broken for llamas
-                    // Incoming click also needs to be fixed
+                    //TODO Body to... something else?
                     slot = 2;
                 }