Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version for enabling offhand swap. #358

Closed
0-x-2-2 opened this issue Feb 21, 2024 · 1 comment
Closed

Wrong version for enabling offhand swap. #358

0-x-2-2 opened this issue Feb 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@0-x-2-2
Copy link

0-x-2-2 commented Feb 21, 2024

if (ProtocolTranslator.getTargetVersion().olderThanOrEqualTo(ProtocolVersion.v1_8) && actionType == SlotActionType.SWAP && button == 40) { // Pressing 'F' in inventory

This was added sometime around 1.16.x, it works in 1.16.5 but not 1.15.2. Currently, this will send impossible packets detectable by anti-cheats however, this probably still works on servers that run native 1.16.5+ but the server has ViaBackwards and the client is using 1.12.2 protocol, etc with ViaFabricPlus.

@FlorianMichael FlorianMichael added the bug Something isn't working label Feb 21, 2024
@FlorianMichael
Copy link
Member

Hello, thanks for reporting this!
After testing I confirmed that they added offhand swapping in 1.16, it's fixed now in the latest dev build on ci.viaversion.com

To address the ViaBackwards thing: In general VFP doesn't care about protocol translation being done by the server.

Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants