feat(data-point/helpers): Do not export type checking functions (#220)

closes #215
ViacomInc · Feb 21, 2018 · 6e54252 · 6e54252
1 parent 8fc75c1
commit 6e54252
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 27 deletions.
diff --git a/packages/data-point/lib/__snapshots__/index.test.js.snap b/packages/data-point/lib/__snapshots__/index.test.js.snap
@@ -10,13 +10,6 @@ Object {
     "constant": [Function],
     "filter": [Function],
     "find": [Function],
-    "isArray": [Function],
-    "isBoolean": [Function],
-    "isError": [Function],
-    "isFunction": [Function],
-    "isNumber": [Function],
-    "isObject": [Function],
-    "isString": [Function],
     "map": [Function],
     "omit": [Function],
     "parallel": [Function],

diff --git a/packages/data-point/lib/helpers/__snapshots__/helpers.test.js.snap b/packages/data-point/lib/helpers/__snapshots__/helpers.test.js.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Helpers API 1`] = `
+exports[`helpers API check what methods are exported in the helpers modules 1`] = `
 Object {
   "createAccumulator": [Function],
   "createEntity": [Function],
@@ -11,13 +11,6 @@ Object {
     "constant": [Function],
     "filter": [Function],
     "find": [Function],
-    "isArray": [Function],
-    "isBoolean": [Function],
-    "isError": [Function],
-    "isFunction": [Function],
-    "isNumber": [Function],
-    "isObject": [Function],
-    "isString": [Function],
     "map": [Function],
     "omit": [Function],
     "parallel": [Function],

diff --git a/packages/data-point/lib/helpers/helpers.js b/packages/data-point/lib/helpers/helpers.js
@@ -4,7 +4,6 @@ const resolveReducer = require('../reducer-types').resolve
 const AccumulatorFactory = require('../accumulator/factory')
 
 const { stubFactories } = require('../reducer-types/reducer-helpers')
-const typeCheckFunctionReducers = require('./type-check-functions')
 
 module.exports.helpers = {
   assign: stubFactories.assign,
@@ -15,14 +14,7 @@ module.exports.helpers = {
   omit: stubFactories.omit,
   parallel: stubFactories.parallel,
   pick: stubFactories.pick,
-  withDefault: stubFactories.withDefault,
-  isString: typeCheckFunctionReducers.isString,
-  isNumber: typeCheckFunctionReducers.isNumber,
-  isBoolean: typeCheckFunctionReducers.isBoolean,
-  isFunction: typeCheckFunctionReducers.isFunction,
-  isError: typeCheckFunctionReducers.isError,
-  isArray: typeCheckFunctionReducers.isArray,
-  isObject: typeCheckFunctionReducers.isObject
+  withDefault: stubFactories.withDefault
 }
 
 module.exports.isReducer = require('../reducer-types').isReducer

diff --git a/packages/data-point/lib/helpers/helpers.test.js b/packages/data-point/lib/helpers/helpers.test.js
@@ -3,9 +3,10 @@
 const _ = require('lodash')
 const helpers = require('./helpers')
 
-test('Helpers API', () => {
-  // To keep an eye on new methods added to the helpers module
-  expect(helpers).toMatchSnapshot()
+describe('helpers API', () => {
+  test('check what methods are exported in the helpers modules', () => {
+    expect(helpers).toMatchSnapshot()
+  })
 })
 
 describe('helpers.reducify', () => {