Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More Background Images #147

Closed
VickiLanger opened this issue Oct 25, 2020 · 15 comments
Closed

Add More Background Images #147

VickiLanger opened this issue Oct 25, 2020 · 15 comments
Labels
Design enhancement New feature or request good first issue Good for newcomers Hacktoberfest Requesting input/assistance from anyone help wanted Extra attention is needed

Comments

@VickiLanger
Copy link
Owner

VickiLanger commented Oct 25, 2020

This will be a running issue to let people know how to add more images to the img_bg directory


Make and add some backgrounds to be used at random for posting on @LGTBTotd on twitter

Requirements for Consistency

  • in one of the standard fonts, include twitter handle @LGBTQotd somewhere on the image
  • Keep the file name convention. Just numbers like 101 or numbers with the letter 'a' like 101a.
  • Must adhere to WCAG accessibility standards for contrast and color blindness with #0b3c49 a dark blue as the text that will be on them.
  • Dimensions should be 1600 x 900 16:9

Standard Fonts

Standard Colors

  • #0b3c49 a dark blue
  • #f2a130 an orangey yellow
  • #444444 a dark gray
  • #86b500 greenish
  • #f4f4f4 almost white, kinda gray

Proposed workflow:

  1. Fork this repo
  2. Add images to img_bg keeping to the existing naming conventions:
    • Each image should have the twitter handle and meet accessibility standards
    • follow the examples in img_bg
  3. Once you are done and checked for typos, commit it & push your work to your fork
  4. Submit a PR against this repo

Someone will look it over and, if deemed appropriate, will merge your PR.

Thanks for contributing!


Don't forget to follow the bot on Twitter to see the hard work you put in.

@VickiLanger VickiLanger added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest Requesting input/assistance from anyone Design labels Oct 25, 2020
@aditisingh2412
Copy link

Hello @VickiLanger I'm a first-timer. I am interested in contributing to this issue.

@VickiLanger
Copy link
Owner Author

@aditisingh2412 I look forward to seeing your pull request.

@wasabi28
Copy link

Hi, I want to contribute to the issue.

@VickiLanger
Copy link
Owner Author

@wasabi28 I look forward to seeing your pull request.

@dianamenesesg
Copy link
Contributor

Hi @VickiLanger! I would like to contribute with my PR as well.

@thomasneil
Copy link
Contributor

Hi @VickiLanger May I contribute to this as well?

@JasirZaeem
Copy link
Collaborator

@VickiLanger Image size is currently assumed to be 1600 x 900 in the script to generate images, if and until that is changed Dimensions of images being added should only be 1600 x 900 so "Dimensions should be 1200 x 675, 16:9 or equivalent" should be changed to tell contributors adding new images the same.

@VickiLanger
Copy link
Owner Author

Thanks, @JasirZaeem. Fixed.

@prankurverma
Copy link
Contributor

Hey @VickiLanger Can I contribute to this as well?

@prankurverma
Copy link
Contributor

Hey @VickiLanger Can I contribute to this as well?

Am I also supposed to add that translucent box with twitter handle?

@VickiLanger
Copy link
Owner Author

@prankurverma It's not required. The most important part is being accessible. So, if there is enough contrast between the background and the #0b3c49 text that will be on the background, then the translucent box isn't needed. I'm open to anything that still adhere's to WCAG accessibility standards

@prankurverma
Copy link
Contributor

@prankurverma It's not required. The most important part is being accessible. So, if there is enough contrast between the background and the #0b3c49 text that will be on the background, then the translucent box isn't needed. I'm open to anything that still adhere's to WCAG accessibility standards

I believe the box is added by some automation or template? Is it fine if I simply add my created background? Or is the box template included in this repo?

@VickiLanger
Copy link
Owner Author

@prankurverma It's not required. The most important part is being accessible. So, if there is enough contrast between the background and the #0b3c49 text that will be on the background, then the translucent box isn't needed. I'm open to anything that still adhere's to WCAG accessibility standards

I believe the box is added by some automation or template? Is it fine if I simply add my created background? Or is the box template included in this repo?

The box was manually placed on each background. I built the first 100 or so files with canvas. Design and stuff isn't really my thing. an example background image

@prankurverma
Copy link
Contributor

Hey @VickiLanger ! I've made a PR #224 for this issue. :)

@VickiLanger
Copy link
Owner Author

WOrking on automating images to make sure images are legit accessible and consistent

#265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design enhancement New feature or request good first issue Good for newcomers Hacktoberfest Requesting input/assistance from anyone help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants