vmagent: respect -usePromCompatibleNaming if no relabeling is set
#3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #3493 Signed-off-by: hagen1778 <roman@victoriametrics.com>
hagen1778
force-pushed
the
issue-3493
branch
from
a3be538
to
4742af2
Compare
Signed-off-by: hagen1778 <roman@victoriametrics.com>
Codecov ReportBase: 57.15% // Head: 57.24% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3511 +/- ##
==========================================
+ Coverage 57.15% 57.24% +0.09%
==========================================
Files 290 290
Lines 50180 50180
==========================================
+ Hits 28678 28726 +48
+ Misses 19667 19620 -47
+ Partials 1835 1834 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
valyala
approved these changes
Dec 20, 2022
|
@hagen1778 , thanks for the bugfix! |
valyala
added a commit
that referenced
this pull request
Dec 20, 2022
…3511) * vmagent: respect `-usePromCompatibleNaming` if no relabeling is set See #3493 Signed-off-by: hagen1778 <roman@victoriametrics.com> * vmagent: upd test Signed-off-by: hagen1778 <roman@victoriametrics.com> Signed-off-by: hagen1778 <roman@victoriametrics.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
|
FYI, this pull request has been included in v1.85.3 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3493
Signed-off-by: hagen1778 roman@victoriametrics.com