Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take in account replicationFactor with dropSamplesOnOverload=true #4798

Open
f41gh7 opened this issue Aug 8, 2023 · 0 comments
Open

Take in account replicationFactor with dropSamplesOnOverload=true #4798

f41gh7 opened this issue Aug 8, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@f41gh7
Copy link
Contributor

f41gh7 commented Aug 8, 2023

Is your feature request related to a problem? Please describe

With the enabled dropSamplesOnOverload setting, samples are dropped before the replication factor was applied, which results in complete data loss instead of data loss only for unavailable vmstorage replica. This confuses users and is misaligned with intuitive understanding of this setting.

Describe the solution you'd like

Redesign the current replication mechanism to allow dropping samples after the replication, so data will be dropped only for overloaded vmstorage node. It should help to prevent cluster degradation when one of vmstorage nodes is slow and other replicas could process metrics ingestion.

@f41gh7 f41gh7 added the enhancement New feature or request label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant