Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"<scalar> <filter-op> <vector>" takes the sample value from the wrong side #673

Closed
juliusv opened this issue Aug 5, 2020 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@juliusv
Copy link

juliusv commented Aug 5, 2020

Describe the bug
In native PromQL, binary filter operators between a scalar and a vector (e.g. 1 < foo) always return the sample value from the vector side of the operation, no matter which side of the operator it is on. VictoriaMetrics always returns the sample value from the left-hand side, even if it is the scalar value.

Version

$ ./victoria-metrics-prod --version
victoria-metrics-20200727-204526-tags-v1.39.1-0-g5b81bdde3
@valyala valyala added the bug Something isn't working label Aug 6, 2020
@valyala
Copy link
Collaborator

valyala commented Aug 6, 2020

@juliusv , thanks for filing the issue!

The issue must be fixed in the commit 68e4f40 , which will be included in the next release of VictoriaMetrics .

@valyala
Copy link
Collaborator

valyala commented Aug 9, 2020

The bugfix has been included in v1.39.4. Closing the bug as fixed.

@valyala valyala closed this as completed Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants