Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger browser authorization dialog in vmauth #680

Closed
ofen opened this issue Aug 7, 2020 · 4 comments
Closed

Trigger browser authorization dialog in vmauth #680

ofen opened this issue Aug 7, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@ofen
Copy link
Contributor

ofen commented Aug 7, 2020

Describe the solution you'd like

  1. Add user in config.yaml
  2. Navigate browser to instance (e.g. http://vmauth:80)
  3. Browser prompt for username and password
  4. Enter correct credential
  5. vmauth route to configured endpoint

Current implementation

  1. Add user in config.yaml
  2. Pass additional args (should be same as in config.yaml):
    • -httpAuth.username=admin
    • -httpAuth.password=12345678
  3. Navigate browser to instance (e.g. http://vmauth:80)
  4. Browser prompt for username and password
  5. Enter correct credential
  6. vmauth route only to configured endpoint with credentials from -httpAuth.username and -httpAuth.password (other routes will result 401 HTTP error code)
@ofen
Copy link
Contributor Author

ofen commented Aug 7, 2020

#681

@valyala valyala added the enhancement New feature or request label Aug 9, 2020
@valyala
Copy link
Collaborator

valyala commented Aug 9, 2020

The commit that adds browser authorization dialog to vmauth has been included in v1.39.4. Closing the issue as done.

@valyala valyala closed this as completed Aug 9, 2020
@ofen
Copy link
Contributor Author

ofen commented Aug 9, 2020

still need to remove -httpAuth.username and -httpAuth.password flags from vmauth because it's leading to only one acceptable basic auth header

@valyala
Copy link
Collaborator

valyala commented Aug 11, 2020

still need to remove -httpAuth.username and -httpAuth.password flags from vmauth because it's leading to only one acceptable basic auth header

Yeah. The temporary workaround is just don't set these flags when running vmauth :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants