Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/vmselect/promql: add day_of_year() function #5368

Merged
merged 4 commits into from Nov 28, 2023

Conversation

luckyxiaoqiang
Copy link
Contributor

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5034aa0) 60.12% compared to head (ce56f5c) 60.13%.
Report is 9 commits behind head on master.

Files Patch % Lines
app/vmagent/remotewrite/remotewrite.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5368   +/-   ##
=======================================
  Coverage   60.12%   60.13%           
=======================================
  Files         399      399           
  Lines       75126    75132    +6     
=======================================
+ Hits        45169    45179   +10     
+ Misses      27445    27444    -1     
+ Partials     2512     2509    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hagen1778 hagen1778 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hagen1778 hagen1778 merged commit d7897e0 into VictoriaMetrics:master Nov 28, 2023
9 of 10 checks passed
@hagen1778
Copy link
Collaborator

Thanks for contribution!

hagen1778 pushed a commit that referenced this pull request Nov 28, 2023
Co-authored-by: dingxiaoqiang <dingxiaoqiang@bytedance.com>
Co-authored-by: Roman Khavronenko <roman@victoriametrics.com>
(cherry picked from commit d7897e0)
@valyala
Copy link
Collaborator

valyala commented Dec 13, 2023

FYI, this pull request has been included in VictoriaMetrics v1.96.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants