Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

futuresCancelBatchOrders lacks return-type annotation #641

Open
bennycode opened this issue Aug 8, 2023 · 3 comments
Open

futuresCancelBatchOrders lacks return-type annotation #641

bennycode opened this issue Aug 8, 2023 · 3 comments

Comments

@bennycode
Copy link
Contributor

The PR #586 introduced type definitions for futuresCancelBatchOrders. 馃殌

Unfortunately, the function is missing a return-type definition which becomes a problem when trying to use it with strictly typed code:

binance-api-node/index.d.ts:666:5 - error TS7010: 'futuresCancelBatchOrders', which lacks return-type annotation, implicitly has an 'any' return type.

@jinusean do you know what the function returns or is it just Promise<void>?

P.S. It's funny that the error occurs in line 666. 馃槇

@uslualper
Copy link

How did you solve this problem? What is the best temporary way?

@bennycode
Copy link
Contributor Author

How did you solve this problem? What is the best temporary way?

I downgraded to binance-api-node v0.12.6 - Does it work for you as well?

@balthazar
Copy link
Member

I can probably revert the PR if @bennycode confirms, not a type expert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants