Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New video player #2387

Open
41 of 53 tasks
moisout opened this issue Nov 7, 2023 · 7 comments
Open
41 of 53 tasks

New video player #2387

moisout opened this issue Nov 7, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request videoplayer something related to the Videoplayer

Comments

@moisout
Copy link
Member

moisout commented Nov 7, 2023

Features

  • Formats
    • Native html5 video
    • MPEG-DASH
    • HLS
  • Compatibility
    • Desktop Browsers
    • Android Browsers
    • iOS Safari
  • Interaction
    • Desktop
      • Keyboard shortcuts
        • Disable keyboard shortcuts when popups are open
        • Spacebar pause/play
        • K pause/play
        • Arrow keys left/right skip forwards/backwards
        • Arrow keys up/down adjust volume
        • M mute
        • J skip backwards
        • L skip forwards
        • F fullscreen
        • 0-9 skip to percentage of video
        • End go to end
        • . if video paused, go to next frame
        • , if video paused, go to previous frame
        • C enable/disable subtitles
        • Shift+N jump to next video
        • Shift+P jump to previous video (when in a playlist)
    • Mobile
      • Gestures
        • Double tap to skip forwards/backwards
        • Tap to show/hide UI
        • Slide to adjust volume
  • Chapters
    • Native YouTube chapters
    • SponsorBlock chapters
  • Sponsorblock
    • Skip button
    • Colors on seek bar
    • Skip to highlight
  • Seek bar preview thumbnails
  • Use Media Session API
    • Play, pause, skip, etc. in notification of device
    • Play, pause, etc. buttons of device
  • End screen cards
  • Subtitles
    • Custom renderer in normal view
    • Native subtitles if video in popup viewer (Firefox/Chromium)
  • In-player settings
    • Video quality selection
    • Audio quality selection
    • Volume control
    • Speed
    • Repeat
    • Audio track selection (language)
    • Captions enable/disable
    • Subtitle language
  • Other settings (in ViewTube settings menu)
    • Default quality (applied as best as possible)
    • How many seconds to skip forwards/backwards
    • SponsorBlock settings
  • Full screen
  • Support embedding
  • Save and restore progress
  • Skip buttons
    • Preview on hover
    • In playlist: previous and next video
    • If autoplay next video enabled, skip button for next video (outside of playlist)
@wnhrt
Copy link

wnhrt commented Apr 9, 2024

If possible, mobile gestures for brightness and volume, like Android VLC or NewPipe, would be nice. When in fullscreen mode, they allow adjusting brightness by moving with one finger up and down on the left half of the screen, and volume doing the same on the right half.

Looking forward to the new player, looks very promising!

@moisout
Copy link
Member Author

moisout commented Apr 10, 2024

If possible, mobile gestures for brightness and volume, like Android VLC or NewPipe, would be nice. When in fullscreen mode, they allow adjusting brightness by moving with one finger up and down on the left half of the screen, and volume doing the same on the right half.

Looking forward to the new player, looks very promising!

Volume would be possible, but websites cannot adjust screen brightness unfortunately

Edit: added to the todo list

@patricgruber
Copy link
Contributor

Just tried the code and have to say the new video player looks really good and and works way better for me (the quality selection is actually enforced).
Great work so far, keep it up!

@patricgruber
Copy link
Contributor

patricgruber commented Jun 6, 2024

I have some ideas for the UX. I know it is a work in progress, but I wanted to share my thoughts.
For the video and audio quality selection and the subtitle selection a dropdown could be sufficient. Then the popup window wouldn't need to be so big and have multiple collapsible panels, which would make the handling a bit easier.
I really like the codecs toggle though!

For the speed settings currently there is a checkbox to change the input type in the same line with the actual speed setting. I think this could be split into two different settings/lines and the Show video speed as a list setting could be moved entirely to the global settings menu, so that the "local" playback settings are relevant for the current video only.

These things don't necessarily need to be implemented and also don't need to be implemented within this one pull request. These small details can be checked again and maybe implemented after the video player is finished.

Since this is a WIP you might have planned this anyway, just wanted to give my two cents. If you need help with some part or just want to offload something to someone else, I'd be happy to help!

Edit: fixed typos

@n-ce
Copy link

n-ce commented Jun 11, 2024

  • iOS Safari

Is it the duration bug?
I'm working on my own project update and I'm having this issue.

@moisout
Copy link
Member Author

moisout commented Jun 11, 2024

  • iOS Safari

Is it the duration bug?
I'm working on my own project update and I'm having this issue.

Playback in general is not working. I haven't heard of that bug tho.

@ac1mx
Copy link

ac1mx commented Jun 14, 2024

I really love the new player, and the fact that it will enforce the quality setting, however the default "Auto" quality setting is somewhat annoying. I'd love to see a default quality setting sometime, if you're up for it! Love the project, and thank you for keeping it maintained!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request videoplayer something related to the Videoplayer
Projects
None yet
Development

No branches or pull requests

5 participants