Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hasAttachments function should test if attachments property exists #184

Open
oldrich-svec opened this issue Mar 28, 2022 · 0 comments
Open

hasAttachments function should test if attachments property exists #184

oldrich-svec opened this issue Mar 28, 2022 · 0 comments

Comments

@oldrich-svec
Copy link

oldrich-svec commented Mar 28, 2022 •
edited

I propose to change

commentModel.hasAttachments = function() {
    return commentModel.attachments.length > 0;
}

to

commentModel.hasAttachments = function() {
    return !!commentModel.attachments && commentModel.attachments.length > 0;
}

as commentModel does not always contain attachments property 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oldrich-svec