Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send comment on "Enter" event #19

Closed
sergiogregorutti opened this issue Nov 2, 2015 · 5 comments
Closed

Send comment on "Enter" event #19

sergiogregorutti opened this issue Nov 2, 2015 · 5 comments
Assignees
Milestone

Comments

@sergiogregorutti
Copy link

Hi,

Many users are familiar with send a comment on Enter (thanks to Facebook?).

I think that it will be a good improvement to have the option of send the comment on Enter event.

Thanks!

@jjtykkyl
Copy link
Contributor

jjtykkyl commented Nov 3, 2015

I thought about this when implementing the library but decided not to implement this as it confuses users in some use cases (I actually deleted this feature in our other project due to confusion). Again, you are more that welcome to implement this yourself as long as this feature can be enabled and disabled (disabled by default).

@sergiogregorutti
Copy link
Author

Thanks for your response. I'm not sure if I can resolve this but I'll try to do my best. If I have news I'll let you know.

@jjtykkyl
Copy link
Contributor

jjtykkyl commented Nov 3, 2015

Just to let you know, I am going to implement some new features to this library in the beginning of next month so I could do this as well.

@sergiogregorutti
Copy link
Author

Cool. You made a really good work with this library. It deserves to be more popular. I'll share it with my co-workers.

Thanks.

@jessenieminen jessenieminen modified the milestones: v, v.1.1 Nov 4, 2015
@jjtykkyl
Copy link
Contributor

I'm happy to let you know that this feature has been implemented to version 1.1.0. You can enable the functionality by setting the new variable "postCommentOnEnter" to true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants