Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom retry timeout upon failure #212

Conversation

sylvain-bouchard
Copy link
Contributor

A small change proposal to allow the use of a custom timeout value in ms rather than using a fixed formula. If such a custom value has been specified, use it, otherwise, fallback to using the existing timeout calculation.

Signed-off-by: Sylvain Bouchard <sylvain.bouchard@ville.montreal.qc.ca>
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #212 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   70.77%   70.80%   +0.02%     
==========================================
  Files          48       48              
  Lines        1054     1055       +1     
  Branches      130      131       +1     
==========================================
+ Hits          746      747       +1     
  Misses        308      308              
Impacted Files Coverage Δ
packages/workit-bpm-client/src/camundaMessage.ts 80.55% <100.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a42ae0c...0bf74ac. Read the comment docs.

Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlivierAlbertini OlivierAlbertini added the enhancement New feature or request label Jun 16, 2020
@OlivierAlbertini OlivierAlbertini merged commit 49c24f4 into VilledeMontreal:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants