Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated background applied on non-included devices. #17

Closed
SeLLeRoNe opened this issue May 2, 2020 · 6 comments
Closed

Animated background applied on non-included devices. #17

SeLLeRoNe opened this issue May 2, 2020 · 6 comments

Comments

@SeLLeRoNe
Copy link
Contributor

Your Animated Background configuration

animated_background:
  default_url: /local/animated_backgrounds/sunny.html
  included_users:
    - Andrea Iannucci
  included_devices:
    - windows
  entity: "weather.dark_sky"
  state_url:
    'sunny': /local/animated_backgrounds/sunny.html
    'partlycloudy': /local/animated_backgrounds/cloudy.html
    'cloudy': /local/animated_backgrounds/cloudy.html
    'mostlycloudy': /local/animated_backgrounds/mostlycloudy.html
    'clear-night': /local/animated_backgrounds/night.html
    'fog': /local/animated_backgrounds/fog.html

Version of Home Assistant 0.109.2
"Latest" is not a version number. Please provide the actual version number.

Describe the bug
Even configuring only "windows" as allowed device, I can see a white background (not the theme background) on the HA Mobile App and using Chrome

Browser console log
Post anything related to animated-background.js

To Reproduce
Steps to reproduce the behavior:

  1. Configure only "windows" as allowd device
  2. Open the UI using a mobile phone browser or HA Companion App

Expected behavior
Not showing a white background but the theme one

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: OnePlus 5
  • OS: OxygenOS 9.0.11 based on Android 9
  • Browser: Chrome
  • Version: 81.0.4044.117
  • App: Home Companion App 1.8.0-159 and Chrome 81.0.4044.117
  • Version: 1.8.0-159

Screenshots
If applicable, add screenshots to help explain your problem.
image

Additional context
Add any other context about the problem here.

@Villhellm
Copy link
Owner

Thanks for the complete reports, that makes things much easier on me. Your two issues were related, but not quite the same, so thank you for submitting them separately.

Please try the latest update to see if your issues are fixed.

@SeLLeRoNe
Copy link
Contributor Author

Yep, updated and everything seems to be working as expected!

Thanks a lot for the quick fix :)
I got one question, I have an improvment in mind that I would like to discuss with you, should I open an issue here ignoring the Bug report template or somewhere else?

@SeLLeRoNe
Copy link
Contributor Author

Oh actually I just notice that a per-view option is already there :D
The only thing would be the ability to disable it per view, maybe is already doable but I cannot see in the docs the way to it

@Villhellm
Copy link
Owner

I’ll add a feature request template as well (I thought I added it when I added the bug report template).

And there definitely should be an option to disable per view. That shouldn’t be too difficult to throw in there. I’ll try to add that today. Thanks for the suggestion!

@SeLLeRoNe
Copy link
Contributor Author

Thanks! :)

@Villhellm
Copy link
Owner

Newest release has the "enabled" config option. It can be applied to the entire configuration or an individual view configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants