fix: Python version #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In flags, exit_on_error is used which was introduced in python 3.9 and in examples u have used `|` for typing.Union which was introduced in 3.10. This breaks backward compatibility
|
Union was not added in 3.10, from the docs it seems like it was added in 3.6. and I think you’re confusing this as | being a new feature in that version |
|
I am not talking about Union. I mentioned about And exit_on_error used in Argument Parser in flags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In flags, exit_on_error is used which was introduced in python 3.9 and in examples u have used
|for typing.Union which was introduced in 3.10. This breaks backward compatibilityChecklist