JoinEagerAlgorithm is not working #684
Comments
|
After little bit of debugging I can see that encParentPath is empty. Did I miss something? OneToOnePathInfo {
path: 'photo',
encPath: 'photo',
encParentPath: '',
modelClass: { [Function: Model] dataLoader: null },
relation:
BelongsToOneRelation {
name: 'photo',
ownerModelClass: { [Function: Model] dataLoader: null },
relatedModelClass: { [Function: Model] dataLoader: null },
ownerProp:
RelationProperty {
_refs: [Array],
_modelClass: [Function],
_props: [Array],
_cols: [Array],
_propGetters: [Array],
_propSetters: [Array] },
relatedProp:
RelationProperty {
_refs: [Array],
_modelClass: [Function],
_props: [Array],
_cols: [Array],
_propGetters: [Array],
_propSetters: [Array] },
joinTableModelClass: null,
joinTableOwnerProp: null,
joinTableRelatedProp: null,
joinTableBeforeInsert: null,
joinTableExtras: [],
modify: [Function: modify],
beforeInsert: [Function: beforeInsert] },
omitCols: {},
children: {},
idGetter: [Function],
relationAlias: 'photo',
parentPath: '' } |
|
It does work. There are hundreds of tests that make sure of it. Could you provide a reproduction? You can use the reproduction-template.js in the repo root. |
|
First of all I will try to fix it by myself. Maybe I missed something. Thanks |
|
That's one of the reasons I always ask for a reproduction: trying to reproduce the problem from the scratch is a great way to find the problem. If the problem ends up being an objection bug, the reproduction makes my life a lot easier. |
|
@seeden What are you using for |
|
I have used your knexSnakeCaseMappers for knex. |
|
I am trying to create minimal example right now. knex:query select * from information_schema.columns where table_name = $1 and table_catalog = $2 and table_schema = current_schema +14ms
knex:bindings [ 'quizCoverPhotoTest', 'quizana' ]as you can see table name is quizCoverPhotoTest but in the table is quizCoverPhotoTest |
|
Here is my reproduction import Knex from 'knex';
import { Model, knexSnakeCaseMappers } from 'objection';
class Photo extends Model {
static modelName = 'PhotoTest';
static tableName = 'photosTest';
static relationMappings() {
return {
quizCoverPhoto: {
relation: this.HasOneRelation,
modelClass: QuizCoverPhoto,
join: {
from: `${this.tableName}.id`,
to: `${QuizCoverPhoto.tableName}.photoId`,
},
},
};
}
}
class QuizCoverPhoto extends Model {
static modelName = 'QuizCoverPhotoTest';
static tableName = 'quizCoverPhotoTest';
static relationMappings() {
return {
photo: {
relation: this.BelongsToOneRelation,
modelClass: Photo,
join: {
from: `${this.tableName}.photoId`,
to: `${Photo.tableName}.id`,
},
},
};
}
static async getPhotos(ids) {
const items = await this
.query()
.whereIn(`${QuizCoverPhoto.tableName}.id`, ids)
.eagerAlgorithm(this.JoinEagerAlgorithm)
.eager('photo');
const byIds = {};
items.forEach(item => byIds[item.id] = item);
return ids.map(id => byIds[id] && byIds[id].photo);
}
}
const knex = Knex({
...knexSnakeCaseMappers(),
client: 'postgresql',
connection: process.env.POSTGRESQL_URL,
// debug: true,
pool: {
min: 5,
max: 15,
idleTimeoutMillis: 30000,
},
migrations: {
tableName: 'knex_migrations',
},
});
const models = {
Photo,
QuizCoverPhoto,
};
// we need to register all models
Object.keys(models).forEach((m) => {
// extend current model
const model = models[m];
model.knex(knex);
});
async function test() {
await knex.schema.dropTableIfExists(QuizCoverPhoto.tableName);
await knex.schema.dropTableIfExists(Photo.tableName);
// init db
await knex.schema.createTableIfNotExists(Photo.tableName, (table) => {
table.increments('id').primary().unsigned();
table.timestamps(true, true);
table.string('name');
});
await knex.schema.createTableIfNotExists(QuizCoverPhoto.tableName, (table) => {
table.increments('id').primary().unsigned();
table.timestamps(true, true);
table
.integer('photoId')
.unsigned()
.notNullable()
.index()
.references('id')
.inTable(Photo.tableName)
.onDelete('CASCADE');
});
// add db items
const photo = await models.Photo
.query()
.insert({
name: 'test',
})
.returning('*');
const quizCoverPhoto = await models.QuizCoverPhoto
.query()
.insert({
photoId: photo.id,
})
.returning('*');
// run code
const [firstPhoto] = await models.QuizCoverPhoto.getPhotos([quizCoverPhoto.id]);
if (firstPhoto) {
console.log('TEST OK');
} else {
console.log('TEST FAILED');
}
console.log('first photo is: ', firstPhoto);
}
test();I think that it is related to previous comment. Objection are trying to download all columns via information_schema.columns but it is using camelCase name for tables. |
|
It looks like knex.columnInfo is not using wrapIdentifier or postProcessResponse. The problem is in the https://github.com/tgriesser/knex/blob/7de07c966a6ab63087b31cbdd10216d3ddbf8230/src/dialects/postgres/query/compiler.js#L79 I am not sure if they are going to fix it because they are very slow :( |
|
I have tried to add snakeCase into the knex and it is working fine now. But it is just local solution |
|
@seeden Did you open an issue in knex github? This should be fixed there. |
|
Actually this is pretty much impossible to fix in objection without copying the knex code to objection for all dialects. There is a possible fix, but it will break if they ever do fix this in knex. |
|
thanks @koskimas you rock 👍 |
|
I am closing this and waiting for merge in knex |
When I use next code
It will produce next SQL query (it is correct)
But after query I can see next error
The text was updated successfully, but these errors were encountered: