selected

[VincyaneBadouard]

• code
• test
• document (V0)
• Sylvain's check (code)
• Geraldine check (doc)

[sylvainschmitt]

• it's okay thanks to NAMESPACES, but take care as selected is a common name
• Up column is not very explicit
• test is above 1s (9.1s), adding sample_n(500) to inventory and decreasing the VO to 10 reduced the timing to 8s for instance, there are still more to do but it might gave you an idea

selected is good to me. Any of my comments is really important. I would understand you don't improve tests for the moment because it doesn't change how the package is working. It is more a suggestion for long term development as keeping short tests make your life easier. Consequently, I'm considering the code as checked.