Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header popup menu opens twice #757

Closed
nminkov opened this issue Feb 7, 2018 · 4 comments
Closed

Header popup menu opens twice #757

nminkov opened this issue Feb 7, 2018 · 4 comments
Assignees
@joachimmarder
Labels
Bug
Milestone
V7.0

Comments

@nminkov
Copy link

nminkov commented Feb 7, 2018

Me again.

We found that the header popup menu is opened twice when right clicked.

In WM_NCRBUTTONUP handler, FColumns.HandleClick(P, mbRight, True, False); is called which opens the menu once , then few lines down Menu.Popup(XCursor, YCursor); opens it a second time.
@joachimmarder joachimmarder self-assigned this Feb 8, 2018
@joachimmarder joachimmarder added this to the V7.0 milestone Feb 8, 2018
@joachimmarder
Copy link
Contributor

We should merge the code from WM_NCRBUTTONUP into TVirtualTreeColumns.HandleClick()

@nminkov
Copy link
Author

nminkov commented Feb 9, 2018 •
edited

Agree, it seems to be the best way
Thanks

joachimmarder pushed a commit that referenced this issue Feb 10, 2018
Merged code for header right click menu from TVTHeader.HandleMessage(…
b24bf75 
…) in TVirtualTreeColumns.HandleClick(). This fixes issue #757 (Header popup menu opens twice).
@joachimmarder
Copy link
Contributor

Done. Would you mind to test the fix? I tested it in our TreeSize Professional and there it worked without problems.

@nminkov
Copy link
Author

nminkov commented Feb 12, 2018 •
edited

It works ask expected. Thanks!

joachimmarder pushed a commit that referenced this issue Jun 12, 2018
Issue #757: Rename unit "VTHeaderPopup" to "VirtualTrees.HeaderPopup"
038c021
joachimmarder pushed a commit that referenced this issue Jun 12, 2018
Issue #757: Renamed unit "VTAccessibility" to "VirtualTrees.Accessibi…
dab6906 
…lity", Renamed unit "VTAccessibilityFactory" to "VirtualTrees.AccessibilityFactory"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joachimmarder joachimmarder

Labels
Bug
Projects
None yet
Milestone
V7.0
Development

No branches or pull requests
2 participants
@joachimmarder @nminkov