Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not mix signed an unsiged types, use integer consequently #892

Closed
joachimmarder opened this issue Apr 1, 2019 · 3 comments
Closed

Do not mix signed an unsiged types, use integer consequently #892

joachimmarder opened this issue Apr 1, 2019 · 3 comments
Labels
Breaking Change Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. Refactoring Internal code changes that improve architecture
Milestone
V8.0

Comments

@joachimmarder
Copy link
Contributor

joachimmarder commented Apr 1, 2019 •
edited

There are code lines that try to work around the singed and unsigned problems like this:
Inc(Integer(Run.TotalCount), Difference);

TotalCount is unsigned while Difference is signed. Code would be more managable and more solid if we would use unsigned values consistently.

This could also help the port to FireMonkey, see #839.
@joachimmarder joachimmarder added Breaking Change Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. Refactoring Internal code changes that improve architecture labels Apr 1, 2019
@joachimmarder joachimmarder added this to the V8.0 milestone Apr 1, 2019
@joachimmarder joachimmarder mentioned this issue Apr 1, 2019
Closed
@Fr0sT-Brutal
Copy link
Contributor

Hmm, weird, I have no warnings at all when I build packages neither in XE2 nor 10.1

@joachimmarder
Copy link
Contributor Author

I have no warnings at all

Sure, warnings are suppressed by the hard casts.

@joachimmarder
Copy link
Contributor Author

Since the initial port to Firemonkey has made a lot of progress, I am closing this issue. There is no more actual problem to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. Refactoring Internal code changes that improve architecture
Projects
None yet
Milestone
V8.0
Development

No branches or pull requests
2 participants
@Fr0sT-Brutal @joachimmarder