ScrollIntoView centers horizontally enen without Columns defined #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends ScrollIntoView to scroll horizontally even when no Columns are defined. The changes are minimal and have been tested in production code for years.
This is handy. For example the following picture shows you a VirtualStringTree decendent VirtualExplorerTree.
After clicking on the directory chardet, it is scrolled into view centered without the user having to scroll horizontally.
Horizontal centering happens only when toCentreScrollIntoView is set and the behavior is the same as if a single column was defined. The behavior is identical to the current code if Columns exist.