Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate config in individual docs pages for sclicheck.DocTests #1965

Open
Gedochao opened this issue Mar 27, 2023 · 0 comments
Open

Isolate config in individual docs pages for sclicheck.DocTests #1965

Gedochao opened this issue Mar 27, 2023 · 0 comments
Labels
internal Internal or build-related changes

Comments

@Gedochao
Copy link
Contributor

Describe what needs to be done and why
sclicheck currently isolates any config sub-command calls within docs-tests.
This prevents the tested settings to leak to other parts of CI builds & tests, but unfortunately does not prevent those settings to leak between individual docs pages tests.
i.e. sclicheck.DocTests.guide proxies currently doesn't run its examples, as the proxy settings would be shared with other docs tests and break them (as proxy settings are shared with coursier).

Ideally, config should be isolated to individual docs' pages tests.

Is your feature request related to a past ticket or discussion?
#1917 (11c56c4 in particular)

Describe alternatives you've considered
We could alternatively isolate each bash code block's config, but that would disable testing the whole flow described in a doc.

@Gedochao Gedochao added the internal Internal or build-related changes label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal or build-related changes
Projects
None yet
Development

No branches or pull requests

1 participant