Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved build target names #2068

Closed
ckipp01 opened this issue May 1, 2023 · 0 comments · Fixed by #2201
Closed

Improved build target names #2068

ckipp01 opened this issue May 1, 2023 · 0 comments · Fixed by #2201
Assignees
Labels
enhancement New feature or request
Projects

Comments

@ckipp01
Copy link
Contributor

ckipp01 commented May 1, 2023

Is your feature request related to a problem? Please describe.

Recently in Metals a pr was merged that offers support for multi-root workspaces. I have a couple different repos that have a main project contained in one directory and a set of scripts contained in another. It used to be that before I always had to re-open that subproject individually to get support. Now with this support, it's no longer necessary to do that! One limitation currently though when using scala-cli is that it's really difficult to actually know if you're looking at the correct build targets or not for your project since they are just random. For example I have a project with a skan and scripts directories. Each their own separate build. Here are the build targets for them:

  • project_a67e43e310-cf755cd196 for skan
  • project_a67e43e310 for scripts

So when I jump back and forth between them it's really hard to know if Metals correctly identifies them.

Describe the solution you'd like

I'd be nice if the build target name was derived maybe from the script or the directory that contains it? For example in my case it'd be much clearer if it was:

  • skan_a67e43e310-cf755cd196 for skan
  • scripts_a67e43e310 for scripts

This might help avoid some confusion for users that are using scala-cli projects with multi-root projects.

Describe alternatives you've considered
Just double-checking the numbers are different and hoping it all works.

@ckipp01 ckipp01 added the enhancement New feature or request label May 1, 2023
@Gedochao Gedochao added this to To do in Issue Board via automation May 10, 2023
@MaciejG604 MaciejG604 self-assigned this Jun 9, 2023
@MaciejG604 MaciejG604 moved this from To do to In progress in Issue Board Jun 9, 2023
@MaciejG604 MaciejG604 moved this from In progress to Done in Issue Board Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants