Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] A new tickMode is needed #951

Closed
da730 opened this issue Sep 14, 2023 · 2 comments · Fixed by #986
Closed

[Feature] A new tickMode is needed #951

da730 opened this issue Sep 14, 2023 · 2 comments · Fixed by #986
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@da730
Copy link
Contributor

da730 commented Sep 14, 2023

What problem does this feature solve?

axis.label.tick.tickMode must support a new mode.
the tick count is related with the height of axis. Higher axis will have more ticks.

What does the proposed API look like?

adding a new mode for tickMode
axis:{
label:{
tick:{
tickMode: 'auto'
}
}
}

or:
make the tickCount support callback function, in which user can get the height of the axis from the parameter and using their own formular to calculate the tick count.

@da730 da730 assigned da730, xuefei1313 and kkxxkk2019 and unassigned da730 Sep 14, 2023
@da730 da730 added the enhancement New feature or request label Sep 14, 2023
@xiaoluoHe
Copy link
Contributor

xiaoluoHe commented Sep 15, 2023

I would prefer the second option: tickcount supports custom function.

@kkxxkk2019 kkxxkk2019 assigned xiaoluoHe and unassigned kkxxkk2019 Sep 15, 2023
@kkxxkk2019
Copy link
Collaborator

I would prefer the second option: tickcount supports custom function.

yes, i agree with you.

@kkxxkk2019 kkxxkk2019 added this to the v1.4.0 milestone Sep 19, 2023
@xiaoluoHe xiaoluoHe linked a pull request Sep 19, 2023 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants