Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced settings break with outside changes #11

Open
remram44 opened this issue May 15, 2015 · 0 comments
Open

Advanced settings break with outside changes #11

remram44 opened this issue May 15, 2015 · 0 comments

Comments

@remram44
Copy link
Member

(originally TRAC#14, 2013-02-28)

reported by benbu

If changes are made to the pipeline while the advanced settings widget is open, (via the builder window or even adding a new plot or variable to another cell), the widget gets out of sync and causes a bunch of issues.

There are a few solutions:

  • Make the advanced setting widget a modal dialog, preventing any other input until it's closed
  • Automatically close the widget when it loses focus (resets unsaved changes)
  • Keep track of pipeline version, and restore that version upon regaining focus

comment by @remram44:

Because the code reuses PortsList from VisTrails, actions get actually created before 'apply' or 'ok' is clicked; resetting only means going back to the one that was selected when we brought up the setting dialog (and doing other changes will branch). This means that the concurrent changes that could happen in VisTrails would actually be interleaved with these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant