Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs version 24 breaks db schema generation #1173

Closed
rexissimus opened this issue May 12, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@rexissimus
Copy link
Member

commented May 12, 2016

vistrails/db/bin/generate.py uses emacs to indent multi-line function arguments. This works in emacs 23, but breaks in emacs 24, probably due to this issue.

The workaround is currently to install emacs 23 before generating the schema.

Can we get rid of the emacs dependency? Perhaps using something like autopep8?

@remram44

This comment has been minimized.

Copy link
Member

commented May 27, 2016

Should autopep8 be added to requirements.txt?

@rexissimus

This comment has been minimized.

Copy link
Member Author

commented May 27, 2016

No, this is only for generating the schema. It is not needed for normal use.

@remram44

This comment has been minimized.

Copy link
Member

commented May 27, 2016

The requirements already list Mako, unittest2 and nose which are not necessary for normal use. I'll split this into requirements.txt and dev-requirements.txt.

@rexissimus

This comment has been minimized.

Copy link
Member Author

commented May 30, 2016

I think at least unittest2 shoud be in requirements.txt. It is used to test the binary builds.

mako/docutils/sphinx may be used by package developers, but this is not essential. They may also be used at runtime to generate dynamic packages, but we discourage that, so it may be good to leave this out.

nose does not seem to be used anywhere, but it was added for scikit-learn so maybe it is needed there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.