Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analogy fails on upgraded and pasted workflows #1175

Open
rexissimus opened this issue Jun 9, 2016 · 2 comments · May be fixed by #1177
Open

Analogy fails on upgraded and pasted workflows #1175

rexissimus opened this issue Jun 9, 2016 · 2 comments · May be fixed by #1177

Comments

@rexissimus
Copy link
Member

rexissimus commented Jun 9, 2016

It seems analogies only work on "original" versions, that has not been upgraded or pasted. This is because the action chain between two versions (A and B) is used as the analogy. On upgraded and pasted workflows the modules are deleted and recreated and there is no way to tell which are the same.

I think we could fix this by computing the minimal action chain (as the workflow edit distance?) between A and B, applied that to A as C and use the diff between A and C as the analogy. We do not seem to have such an algorithm? But I know some people have been working on this.

@remram44
Copy link
Member

Complexity is higher but a function of the number of modules, so this should be doable?

We don't preserve the identity of modules across upgrades (action is just "delete some modules and create some modules"), so I see no easy fix...

@dakoop
Copy link
Member

dakoop commented Jun 13, 2016

Would it help to allow a mapping to be generated with the upgrade? To clarify, my understanding of the issue is: Given versions A and B and their respective upgrades A' and B', the path from A' -> B' is not useful in defining the changes between A' and B' because many of the changed modules are substituted on both ends. This may be another argument for version tree edits, but it seems like an understanding of how the modules are changed in an upgrade is important. Certainly, we could compute some actions between workflows but this eliminates the use of the actual provenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants