Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopping cart added based on rock band #1135

Merged
merged 7 commits into from Apr 30, 2021
Merged

Shopping cart added based on rock band #1135

merged 7 commits into from Apr 30, 2021

Conversation

recursiveway
Copy link
Contributor

@recursiveway recursiveway commented Apr 22, 2021

Related Issue

  • Info about Issue or bug

Closes: #792

Checklist:

  • My code follows the style guidelines of this project.

  • I have performed a self-review of my own code.

  • I have commented my code, particularly in hard-to-understand areas.

  • New and existing unit tests pass locally with my changes.

Screenshots

Put any screenshot(s) of the project here.

@991rajat
Copy link
Contributor

  1. Add the project to script.js
  2. Reduce the size of the gif. If not able to do reduce the duration and resolution, try again. If not able tow work replace it with static image.
    Make the gif under 500KB or so.

@recursiveway
Copy link
Contributor Author

@991rajat I have made the change but now it is showing that i have deleted the files what should i do

@991rajat
Copy link
Contributor

@bug-debug-done Which Files ?
Add the project to script.js

@recursiveway
Copy link
Contributor Author

@bug-debug-done Which Files ?
Add the project to script.js

I made the changes and after that when I checked git status it showed that the files are deleted

@recursiveway
Copy link
Contributor Author

recursiveway commented Apr 26, 2021

@991rajat @ridsuteri @harshgupta20 @Vishal-raj-1 @urvashi-code1255 done with the changes please have a look

@recursiveway recursiveway mentioned this pull request Apr 27, 2021
@recursiveway
Copy link
Contributor Author

@ridsuteri resolved the confilct

@recursiveway
Copy link
Contributor Author

@991rajat hey can you please review this pr

@991rajat
Copy link
Contributor

991rajat commented Apr 28, 2021

@bug-debug-done Looks Great. Just reduce the size of the gif. If not able to make it under 1MB replace it with static image.
Let me know I'll merge it right away.

@recursiveway
Copy link
Contributor Author

@991rajat ok

@991rajat
Copy link
Contributor

991rajat commented Apr 28, 2021

Let me know, when you are done with the changes.

@recursiveway
Copy link
Contributor Author

@991rajat I am trying to update the repo but not able to I am grtting " failed to push some refs to 'https://github.com/bug-debug-done/Awesome-JavaScript-Projects.git'"

@recursiveway
Copy link
Contributor Author

@991rajat done with every thing

@recursiveway
Copy link
Contributor Author

@991rajat hey I have made the changes

@991rajat 991rajat merged commit 2c6d7a7 into Vishal-raj-1:main Apr 30, 2021
@991rajat
Copy link
Contributor

Thanks for this awesome contribution. 🤩
Keep Contributing.

@991rajat 991rajat added level3 25 points and removed level2 15 points labels Apr 30, 2021
@recursiveway
Copy link
Contributor Author

@991rajat thankyou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shopping Cart
2 participants