Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Popup was not looking a little bit different + root variables in global css so that changes become easy #7

Merged
merged 3 commits into from Feb 24, 2022

Conversation

pushkarydv
Copy link
Contributor

Template popup was not so much different from document so it has been given a border same as the theme

  • a id has been added to popup and that id provides border color according to theme defined in global.css
  • applied on all themes
    one example is here:
    cyan

root variables in global css

  • colors were being rewritten a lot of times in global css so i've defined all colors and their light also in root variables and used them everywhere, tested 👍
  • This will also help in easily maintaining theme colors

@vercel
Copy link

vercel bot commented Feb 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vishwagauravin/pro-writer/4sVKcHKc3r19oTgMQ3AdmF94bhJW
✅ Preview: https://pro-writer-git-fork-pushkarydv-master-vishwagauravin.vercel.app

@VishwaGauravIn
Copy link
Owner

Border is not added purposely

@VishwaGauravIn VishwaGauravIn merged commit fd9136b into VishwaGauravIn:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants