Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Add/Edit a product #132

Closed
AmandaDLyon opened this issue Jul 9, 2020 · 6 comments · Fixed by #141
Closed

Cannot Add/Edit a product #132

AmandaDLyon opened this issue Jul 9, 2020 · 6 comments · Fixed by #141
Assignees

Comments

@AmandaDLyon
Copy link

Describe the bug
In the management platform, when trying to add or edit a product, the images are successfully uploaded (in the S3 bucket), however, the product does not get added to the database. Refer to the screenshots below to get an understanding of the errors.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the management webclient
  2. Try adding a product or editing the text of any existing product
  3. Hit Edit
  4. A red notification with pop up stating that the product cannot be edited (not the exact language but you get the idea)

Expected behavior

Post the images being successfully uploaded to S3, the products details (JSON) should be successfully added to the product catalogue (database)

Screenshots
The errors are the same, whether you are editing an existing product or adding a new one. The ones below were created when I was editing an existing product.

Screenshot 2020-07-07 at 2 53 37 PM

Screenshot 2020-07-09 at 12 48 16 PM

Screenshot 2020-07-09 at 12 48 28 PM

Screenshot 2020-07-09 at 12 48 48 PM

@Viveckh @smaharj1

@AmandaDLyon AmandaDLyon mentioned this issue Jul 9, 2020
@gfyre
Copy link
Contributor

gfyre commented Jul 9, 2020

@AmandaDLyon I actually had never tried to add or edit a product in through the dashboard. However, I just took a look at it and I am facing the same issue.

@Viveckh I think that this is quite a pressing issue. Could it be the S3 bucket policies or CORS causing this issue.

It seems like circular-json is failing or is misconfigured. Can you check to see if the same issue persists on your end?

I am tagging @smaharj1 as well.

@AmandaDLyon
Copy link
Author

@smaharj1 @Viveckh Any solution or suggestion guys? I am really really looking forward to your help!!

@AmandaDLyon
Copy link
Author

@smaharj1 @Viveckh this is actually funny. The error exists only when you are adding or editing a product. However, the action that you were trying to do would actually happen.

For example, if you are adding a product, it will show an error, but then the product is actually added to the catalogue. Same goes for editing a product.

What needs to be done here?

@AmandaDLyon
Copy link
Author

So now that I am sort of able to upload a product (although that weird-ass issue needs to be fixed), the issue is now on the shopping-client where the images don't load. I get a Code 301, which is basically saying that the image has been Moved Permanently.

@smaharj1 @Viveckh what can I do here? Somehow, after changing the bucket URL (I am using ap-south-1), it is still able to load the veniqa bucket and not images from my bucket. Where would I change the config for this?

@smaharj1
Copy link
Collaborator

The issue you are seeing is most probably with communication with S3. Look into bucket policies and who can access the bucket.

Sorry for not replying earlier. All the founders of this involved in multiple projects. So, this has been kind of in a back burner

@Viveckh Viveckh linked a pull request Aug 19, 2020 that will close this issue
11 tasks
@Viveckh
Copy link
Owner

Viveckh commented Aug 19, 2020

I made a bucket policy update for images and also hosted our demo servers in the same domain as the frontends. With this, the product add/edit seems to function flawlessly in our demo sites. The circular json issue still needs addressing if it persists, but I did not notice that error on the live version during test.

There's a new documentation update here if you guys are experiencing issues configuring your S3 bucket for images.

@Viveckh Viveckh self-assigned this Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants