Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Autoscroll Behaviors #306

Open
okennedy opened this issue Jan 27, 2024 · 0 comments
Open

Review Autoscroll Behaviors #306

okennedy opened this issue Jan 27, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@okennedy
Copy link
Contributor

What pain point is this feature intended to address? Please describe.
Vizier's autoscroll feels... not quite intuitive. This is hard to pin down, but simply put, there are situations where Vizier should scroll something into view, but doesn't. A few specific examples:

  • When a cell is running, cell outputs don't automatically scroll into view.
    • Note 1: We don't want cell messages to always scroll into view... if we're looking at a different part of the workflow, it can be annoying if the notebook keeps scrolling cells into view. One thought for a heuristic might be:
      • Is the bottom of the cell in view prior to the insertion of the new message?
      • Has the user scrolled in the extremely recent past (e.g., 100-200ms)
    • Note 2: The real pain point here is when I'm editing the last cell in a workflow. Re-running the cell clears the cell messages, scrolling the window so that the output is exactly hidden.
  • When scrolling to a cell (e.g., clicking in the ToC or clicking in the artifact list), the scroll jumps to the cell midpoint. This works for small cells (e.g., cells with height <= display height), but once the cell gets bigger (e.g., as a result of lots of outputs) the midpoint is useless. If the cell is bigger than the display, here's some thoughts on heuristics
    • Scrolling to a specific artifact should probably display the artifact itself
    • Scrolling to the cell from the ToC should align the top of the cell with the top of the display. If the code block is bigger than the screen, maybe we align the bottom of the code block with the bottom of the display?
@okennedy okennedy added the enhancement New feature or request label Jan 27, 2024
@okennedy okennedy added this to the Version 2.1 milestone Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant