Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findPoster throwing 'file not found' on all image extensions that aren't available. #14

Closed
MindSculpt opened this issue Aug 21, 2014 · 9 comments

Comments

@MindSculpt
Copy link

Typically you'd only need one type of fallback image, so you'd never need to load multiple formats (plus it's unlikely anyone would save out multiple background formats for the same poster image).

Ideally you'd want to pull whatever poster image source format is specified and load only that one, regardless of the extension, so Vide doesn't try to find and load images that don't exist.

@vodkabears
Copy link
Owner

Yes, but to specify the format, an additional option is required. So it will be necessary to write data-vide-options to set it.

@MindSculpt
Copy link
Author

I'm not following what you mean -- I don't see an option in the source that would allow me to specify the file type. I know another contributor had a solution for this but it looks like it was removed from this recent release.

PS -- The image errors are also occurring on your demo page: http://vodkabears.github.io/vide/

@MindSculpt
Copy link
Author

Any update on this?

@vodkabears
Copy link
Owner

So, i will restore the option that would allow to specify the poster type.

vodkabears added a commit that referenced this issue Aug 28, 2014
@rufusdenne
Copy link

+1 this issue.

@vodkabears
Copy link
Owner

@rufusdenne use posterType option. I released Vide 0.1.2.

@rufusdenne
Copy link

Thanks for the update. Even with that commit and setting "posterType" to "detect", I'm still seeing the same errors. So is the Vide homepage @vodkabears.

@vodkabears
Copy link
Owner

Yes, there is no way to avoid getting 404 error in the console with "detect". It is asynchronous auto-detection, which sends several requests to the server, so this all requests appear in the console. It's not an issue.

If you want to reduce the number of requests to one without any 404 errors, the only way is to disable auto-detection.

@rufusdenne
Copy link

Thanks for the clarification @vodkabears, that's helped me fix it. Really love Vide by the way - you've done an awesome job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants