Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] WDF Structures #23

Closed
VoidSec opened this issue Apr 25, 2022 · 4 comments
Closed

[BUG] WDF Structures #23

VoidSec opened this issue Apr 25, 2022 · 4 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@VoidSec
Copy link
Owner

VoidSec commented Apr 25, 2022

In commit 43eba17 I've finished updating IDA's APIs and fixing breaking code changes.

Unfortunately, despite the script is not breaking anymore, it seems that it still fails this condition at:

if ida_bytes.create_struct(wdf_func, size, id) and idc.set_name(wdf_func, 'WdfFunctions', 0):

for a reason that, at the moment, is unknown. The logic behind https://github.com/VoidSec/DriverBuddyReloaded/blob/main/DriverBuddyReloaded/wdf.py is pretty "hacky" and somewhat "obscure". In addition to that, I'm not sure that the logic detecting the WDF version at

version = int(str(idc.get_wide_dword(addr + ptr_size + 0x4)))
makes complete sense.

We should also update the WDF structures in order to include updated ones and keep them updated as I'm pretty sure the latest WDF version is >= 1.13.

@VoidSec VoidSec added bug Something isn't working help wanted Extra attention is needed labels Apr 25, 2022
@VoidSec VoidSec self-assigned this Apr 25, 2022
@VoidSec
Copy link
Owner Author

VoidSec commented Apr 25, 2022

@harelon / @eranzim do you think you could give it a try and try to understand and fix that?

@VoidSec VoidSec assigned VoidSec and unassigned VoidSec Apr 25, 2022
@harelon
Copy link
Contributor

harelon commented Apr 29, 2022

Working on it

@VoidSec
Copy link
Owner Author

VoidSec commented May 5, 2022

@harelon thank you! I've seen your pull request; I'll test it this weekend and merge it consequently :D

@VoidSec
Copy link
Owner Author

VoidSec commented May 7, 2022

fixed in #24

@VoidSec VoidSec closed this as completed May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants