Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong 7.1.4 output in Cavernize #56

Closed
VoidXH opened this issue Jan 5, 2023 · 48 comments
Closed

Wrong 7.1.4 output in Cavernize #56

VoidXH opened this issue Jan 5, 2023 · 48 comments
Assignees
Labels

Comments

@VoidXH
Copy link
Owner

VoidXH commented Jan 5, 2023

DD+ Atmos channel tests look like they use the asymmetric renderer. Add tests so this doesn't happen again.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 5, 2023

Fixed in be4d984 and released.

@VoidXH VoidXH closed this as completed Jan 5, 2023
@kaedewang
Copy link

TRR is OK.
And how about these, are they correct?
图片
图片

@kaedewang
Copy link

These unwanted output seems only to happen after pink noise.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 6, 2023

Sadly, this is proven a compression issue. Please use the version from a Dolby Atmos Demo Disc, that has no such issues with triple the bitrate:
test tones demo disc

@kaedewang
Copy link

EN? But I try to decode the same file by DRP. There is no such issue.
And there is only thd track(no EAC3) from my Demo Disc.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 6, 2023

That can't be, all my demo discs have DD+ 7.1 tracks next to the THD. This distortion is there on the JOC level, the mixer is fine.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 6, 2023

But they do not. They have all AC3 core inside, AC3 core is inside EAC3 Atmos tracks.

That's one of the few, here's every track from a demo content (example file):

  • TrueHD 7.1 + Atmos
  • DD+ 7.1 + Atmos
    • Substream 0: DD 5.1 compatibility track
    • Substream 1: Surrounds and rears overriding the old surrounds, resulting in 7.1
  • Mandatory DD 5.1 companion track telling you to use Atmos

The correct version of this test has a 7.1 DD+ track originally:
image

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 6, 2023

Did you check DRP?

I don't have it.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 6, 2023

It already happens in ADM or base layer (compare base layer decoding to ffmpeg)? Or you need 3rd stage (render)?

The channel decoding gives the exact same results as FFmpeg, and the renderer is well tested since the bug fix, it has no distortion. Object placements are correct, the issue is in the JOC decoder/documentation.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 7, 2023

There was a -6 dB FBW gain which was removed today, that's the gain difference. The extra noise you are seeing in the old version is the result of the asymmetric renderer (which is not using balanced-based rendering and always adds sound to neighboring channels) that was triggered by the wrong channel layout, that was also fixed.

It's pretty strange that issues only appear when something was already played, looks like the JOC matrices didn't reset to zero. That might have been because I missed part of the standard, but that needs some debugging.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 7, 2023

Névtelen

I was wrong, issues were in the AC-3 decoding, not in the JOC. For some reason, it has this huge crosstalk, these are the decoded raw FBW channels. The JOC threw away anything before the first sample for each channel, that's why you couldn't see the issues there.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 7, 2023

Fixed in 5a2fe5d and released.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 7, 2023

That wasn't anything related to DRC, I never even implemented DRC. The LFE is contained at wrong gains for E-AC-3, and FFmpeg actually causes clipping for this demo.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 7, 2023

So Dolby did a mistake?? Same bug on Blu-ray?

It's probably an FFmpeg bug. I don't see a clause for this in the spec.

Well, it is not like there are no bugs there too, just 2 days ago

That's SPX, Cavern doesn't even support it as it's unused.

@kaedewang
Copy link

It's cool. Volume seems to be normal, too.
wav file is too large. I put the snapshot by DRP.
图片

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 8, 2023

Is this the DRP result? Because it has clipping LFE like FFmpeg.

@kaedewang
Copy link

Because it has clipping LFE like FFmpeg

Yes,LFE of dolby-test-tones_7_1_4 is louder than other version.
I try another version called 7.1.4. There is no clipping.
图片

@kaedewang
Copy link

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 8, 2023

I try another version called 7.1.4. There is no clipping.

Is that the Atmos demo disc version?

@kaedewang
Copy link

Is that the Atmos demo disc version?

I don't know. I download single m2ts from web.

@kaedewang
Copy link

$ md5sum.exe 7.1.4.m2ts
3894800dd2d3c83edd0eb8911d851094 *7.1.4.m2ts

@kaedewang
Copy link

EE362F6275170762D9A74C4C8C8A9F53

I have this version. But this version only has thd track.
图片

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 8, 2023

Thank you for this file, it has been fixed too in the latest release.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 9, 2023

Then why does Audition does not see it?

It will render at the correct channels. The file order doesn't matter if the metadata contains which channel is which, and Cavernize exports do. It's also the only correct order if you don't contain metadata, it will also work without the WAVEFORMATEX header.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 9, 2023

None. Audition displays the file's channel order, and renders all of them at the correct channels. DRP exports with the correct channel names.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 9, 2023

Then they don't support the WAV channel mask correctly. It's always backs before sides for WAV. Dune has it even worse, they think it's L R C LS LR RR RS LFE...

@kaedewang
Copy link

@VoidXH Could you please add an option to swap ch5/6 and ch7/8,it will be very useful for me.

@VoidXH
Copy link
Owner Author

VoidXH commented Jan 24, 2023

So that is still a bug, you are supposed to only remove half of it (?)...

More than likely there should be a -3 dB decrease only. There are no gain values in the OAMD/JOC (well, there are, they just say 0 dB), so I think I should use the ones from the (E-)AC-3, I just don't know which one, because program level is absolute and dowmix level is always -3, even when it shouldn't be. What is the result of the reference player for overwatch? Is it also clipping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants
@VoidXH @kaedewang and others