-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong 7.1.4 output in Cavernize #56
Comments
Fixed in be4d984 and released. |
These unwanted output seems only to happen after pink noise. |
EN? But I try to decode the same file by DRP. There is no such issue. |
That can't be, all my demo discs have DD+ 7.1 tracks next to the THD. This distortion is there on the JOC level, the mixer is fine. |
That's one of the few, here's every track from a demo content (example file):
The correct version of this test has a 7.1 DD+ track originally: |
I don't have it. |
The channel decoding gives the exact same results as FFmpeg, and the renderer is well tested since the bug fix, it has no distortion. Object placements are correct, the issue is in the JOC decoder/documentation. |
There was a -6 dB FBW gain which was removed today, that's the gain difference. The extra noise you are seeing in the old version is the result of the asymmetric renderer (which is not using balanced-based rendering and always adds sound to neighboring channels) that was triggered by the wrong channel layout, that was also fixed. It's pretty strange that issues only appear when something was already played, looks like the JOC matrices didn't reset to zero. That might have been because I missed part of the standard, but that needs some debugging. |
Fixed in 5a2fe5d and released. |
That wasn't anything related to DRC, I never even implemented DRC. The LFE is contained at wrong gains for E-AC-3, and FFmpeg actually causes clipping for this demo. |
It's probably an FFmpeg bug. I don't see a clause for this in the spec.
That's SPX, Cavern doesn't even support it as it's unused. |
Is this the DRP result? Because it has clipping LFE like FFmpeg. |
@ValZapod Please try this. |
Is that the Atmos demo disc version? |
I don't know. I download single m2ts from web. |
$ md5sum.exe 7.1.4.m2ts |
Thank you for this file, it has been fixed too in the latest release. |
It will render at the correct channels. The file order doesn't matter if the metadata contains which channel is which, and Cavernize exports do. It's also the only correct order if you don't contain metadata, it will also work without the WAVEFORMATEX header. |
None. Audition displays the file's channel order, and renders all of them at the correct channels. DRP exports with the correct channel names. |
Then they don't support the WAV channel mask correctly. It's always backs before sides for WAV. Dune has it even worse, they think it's L R C LS LR RR RS LFE... |
@VoidXH Could you please add an option to swap ch5/6 and ch7/8,it will be very useful for me. |
More than likely there should be a -3 dB decrease only. There are no gain values in the OAMD/JOC (well, there are, they just say 0 dB), so I think I should use the ones from the (E-)AC-3, I just don't know which one, because program level is absolute and dowmix level is always -3, even when it shouldn't be. What is the result of the reference player for overwatch? Is it also clipping? |
DD+ Atmos channel tests look like they use the asymmetric renderer. Add tests so this doesn't happen again.
The text was updated successfully, but these errors were encountered: