Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability suggestions #2

Open
adampatterson opened this issue Nov 26, 2023 · 5 comments
Open

Usability suggestions #2

adampatterson opened this issue Nov 26, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@adampatterson
Copy link

I'm very slow and implementing Editor JS 馃槀

  1. your plugin is really the only one that supports multiple images properly
  2. I love the fact that you have a Gallery and Carousel

The only thing I am trying to make better or would love to see is a clear indication of what each block is while editing content.

If you add the block as a slider, you don't know it's a slider.
If you change it to Fit, you don't know it's a gallery.

I have customized the languages of the caption and button text, which does work really well, except now I have 2 blocks that have the ability to become a Slider or a Gallery so the context is wrong.

gallery: {
    class: ImageGallery,
    config: {
        captionPlaceholder: 'Gallery Caption',
        buttonContent: 'Add an image to the Gallery',
    },
},
carousel: {
    class: ImageGallery,
    config: {
        captionPlaceholder: 'Carousel Caption',
        buttonContent: 'Add an image to the Carousel',
    },
},

It might be a lot more straightforward if the Tune name was displayed above the block like this.

image

Lastly, if it would be possible to add Internationalization support for the Tune names that should complete my wish list 馃槀

I'm using Editor.JS and your plugin inside of a kind of blog editor that will have a Media focus.

As a note I have forked the repo and tried to make the modification but working with the package locally and trying to build the app has been tricky. I had it working at one point and I think updated Node and that broke the link and my project that uses Vite / Rollup seems to have issues with packages that are symlink folders.

Any tips for working on the package locally? There's a possibility I can make these changes and submit a pull request if you like.

@VolgaIgor
Copy link
Owner

Hello!
Thank you for your useful comments and suggestions!

I think I can add internationalization in the nearest future. In addition, I think it鈥檚 worth adding the option to disable tunes for a two block use case.

But need to think about find a better place to add the signature of the current tune)

@VolgaIgor VolgaIgor added the enhancement New feature or request label Nov 29, 2023
@VolgaIgor VolgaIgor self-assigned this Nov 29, 2023
@adampatterson
Copy link
Author

Thanks so much 馃槃

@adampatterson
Copy link
Author

Hey @VolgaIgor

I attempted to make this change myself but for the life of me can't figure out how to get the tune value passed into the UI.

I added a UI element that's essentially a heading that I had planned to display the tune value.

Maybe I'm doing it wrong, It might be possible to do it with CSS if the tune can update a class name or something on the block wrapper.

I'm terrible with javascript though.

@VolgaIgor
Copy link
Owner

VolgaIgor commented Jun 13, 2024

Hello! Sorry it's been so long, I've only just got time now.

@adampatterson
Copy link
Author

Thanks so much, when I get a chance I'll pull the latest version and update my app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants