Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Auto/Static Minimize label width and show/hide Minimize label #144

Merged
merged 10 commits into from
Apr 3, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #140

@vitPinchuk vitPinchuk requested a review from asimonok April 1, 2024 09:01
@vitPinchuk vitPinchuk self-assigned this Apr 1, 2024
@vitPinchuk vitPinchuk changed the title Added Auto/Static Minimize label width, and show/hide Minimize label Auto/Static Minimize label width, and show/hide Minimize label Apr 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (45a870d) to head (829dda2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   98.80%   98.81%   +0.01%     
==========================================
  Files          55       56       +1     
  Lines        1173     1186      +13     
  Branches      322      332      +10     
==========================================
+ Hits         1159     1172      +13     
  Misses         14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Apr 1, 2024
@mikhail-vl mikhail-vl added this to the Version 3.0.0 milestone Apr 1, 2024
@mikhail-vl mikhail-vl changed the title Auto/Static Minimize label width, and show/hide Minimize label Update Auto/Static Minimize label width and show/hide Minimize label Apr 2, 2024
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix Select width when labelWidth=auto
Screenshot 2024-04-02 at 09 21 33

@asimonok asimonok self-requested a review April 2, 2024 11:57
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@asimonok asimonok requested a review from mikhail-vl April 2, 2024 11:57
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 482101d into main Apr 3, 2024
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/update-label-minize-view branch April 3, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic/auto/static Minimize label width
4 participants