Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for always visible search filter #83

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Nov 7, 2023

Resolves #82

Option makes search field is always visible and hides filter button
Screenshot 2023-11-07 at 08 44 04

@asimonok asimonok self-assigned this Nov 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d6452f7) 98.16% compared to head (5cebf77) 98.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   98.16%   98.17%   +0.01%     
==========================================
  Files          51       51              
  Lines         819      824       +5     
  Branches      168      169       +1     
==========================================
+ Hits          804      809       +5     
  Misses          2        2              
  Partials       13       13              
Files Coverage Δ
src/components/Table/Filter.tsx 100.00% <100.00%> (ø)
src/components/Table/Table.tsx 95.23% <100.00%> (ø)
src/components/TableView/TableView.tsx 100.00% <100.00%> (ø)
src/constants/panel.ts 100.00% <100.00%> (ø)
src/module.ts 100.00% <100.00%> (ø)
src/types/panel.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 8, 2023
@mikhail-vl mikhail-vl added this to the Version 2.1.0 milestone Nov 8, 2023
@mikhail-vl mikhail-vl changed the title Always visible search Add an option for always visible search input Nov 8, 2023
@mikhail-vl mikhail-vl changed the title Add an option for always visible search input Add an option for always visible search filter Nov 8, 2023
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit b5d9e54 into main Nov 8, 2023
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/always-visible-search branch November 8, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make option for Search to be always visible
3 participants