Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: code and performance optimizations #1

Merged
merged 6 commits into from Feb 28, 2022
Merged

perf: code and performance optimizations #1

merged 6 commits into from Feb 28, 2022

Conversation

null8626
Copy link
Contributor

  • switched from node-fetch to undici since it has 0 dependencies and was made by the Node.js organization.
  • made so that readConfig() won't do I/O calls every time you call it. the config data should be stored in a global variable called configData, writeConfig() would also overwrite this.
  • other misc code refactors. see changes in commits.

VoltrexKeyva
VoltrexKeyva reviewed Feb 28, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
null8626 and others added 2 commits February 28, 2022 13:05
@null8626 @VoltrexKeyva
fix: as voltrex suggested
9aaec0a 
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@null8626
fix: fix constant 5XX
94212ca
VoltrexKeyva
VoltrexKeyva approved these changes Feb 28, 2022
View reviewed changes
Copy link
Owner

@VoltrexKeyva VoltrexKeyva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@VoltrexKeyva VoltrexKeyva merged commit 9742050 into VoltrexKeyva:main Feb 28, 2022
@null8626
Copy link
Contributor Author

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@null8626 @VoltrexKeyva