Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(textfield): add the no-actions-sync attribute #1013

Merged
merged 6 commits into from
Aug 11, 2021

Conversation

YonatanKra
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2021

鈿狅笍 No Changeset found

Latest commit: bcfb1b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

馃殌

Latest successful build of the PR deployed here.

馃殌

Copy link
Contributor

@yinonov yinonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance of keeping the previous formatting? it appears as if there were so many changes but only small portion should have changed

@YonatanKra
Copy link
Contributor Author

any chance of keeping the previous formatting? it appears as if there were so many changes but only small portion should have changed

Lots of work to revert for a less readable format. Necessary?

@yinonov
Copy link
Contributor

yinonov commented Aug 10, 2021

any chance of keeping the previous formatting? it appears as if there were so many changes but only small portion should have changed

Lots of work to revert for a less readable format. Necessary?

of course, how else can we review changes with all the noise? did it locally

components/textfield/src/vwc-textfield.ts Outdated Show resolved Hide resolved
components/textfield/src/vwc-textfield.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@yinonov yinonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issues in code should have been probably tested and break by the changes. my miss...

@YonatanKra
Copy link
Contributor Author

@yinonov
Any more comments?

@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2021

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@YonatanKra
Copy link
Contributor Author

any chance of keeping the previous formatting? it appears as if there were so many changes but only small portion should have changed

Lots of work to revert for a less readable format. Necessary?

of course, how else can we review changes with all the noise? did it locally

BTW - that's one thing prettier solves. We removed it long time ago :)

@YonatanKra YonatanKra merged commit 850297f into master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants