New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vwc-banner): add aria live polite #1093
Conversation
🚀 Latest successful build of the PR deployed here. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
banner repeats the text on 1st open
reproduce:
- open banner basic story
- open screen reader
- click close on banner
- when banner opens it will pronounce the message twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why dont we just import the material accessible snackbar directive?
@Vonage/vivid-core any takes on testing screen readers behavior? |
We can import the material accessible snackbar directive, I didn't do it at first as I thought that we might need to make some adjustments, but it works as is. The repeated text only occurs in the basic story. |
…ivid into viv-693-vwc-banner-aria
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: