Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): ghost button connotation colors #1108

Merged
merged 8 commits into from Nov 5, 2021
Merged

fix(button): ghost button connotation colors #1108

merged 8 commits into from Nov 5, 2021

Conversation

rachelbt
Copy link
Contributor

What was done:

  • added the connotation colors to ghost button
  • changed the default regular padding from 14 to 16, and the enlarged from 24 to 20 as part of QA with Joella

Screenshots:

image

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

yinonov
yinonov reviewed Oct 28, 2021
View reviewed changes
Copy link
Contributor

@yinonov yinonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did all these snapshot contained buttons?

@rachelbt
Copy link
Contributor Author

did all these snapshot contained buttons?

All apart from text

@rachelbt rachelbt requested a review from yinonov October 31, 2021 09:20
@sonarcloud
Copy link

sonarcloud bot commented Nov 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yinonov yinonov merged commit 515c987 into master Nov 5, 2021
@yinonov yinonov deleted the VIV-679-ghost-button branch November 5, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YonatanKra YonatanKra Awaiting requested review from YonatanKra

@yinonov yinonov Awaiting requested review from yinonov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rachelbt @yinonov